Fix unwanted roll #5083

[NathanMOlson]

Launch Checklist

Fix #5083.

Use spherical linear interpolation only when startRoll != endRoll. Otherwise, use linear interpolation of Euler angles.

• Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• Briefly describe the changes in this PR.
• Link to related issues.
• Write tests for all new functionality.
• Add an entry to CHANGELOG.md under the ## main section.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (985b657) to head (61cb696).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5092      +/-   ##
==========================================
+ Coverage   91.81%   91.82%   +0.01%     
==========================================
  Files         278      278              
  Lines       38318    38346      +28     
  Branches     6703     6704       +1     
==========================================
+ Hits        35181    35212      +31     
+ Misses       3004     3001       -3     
  Partials      133      133              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[HarelM]

It might be better to define a type for this method to pass the parameters as there are many parameters now, too many for my taste...

[HarelM]

We've just migrated the code to vitest, I'm trying to figure out if the coverage reports is accurate.
Cc: @birkskyum

[birkskyum]

We've just migrated the code to vitest, I'm trying to figure out if the coverage reports is accurate. Cc: @birkskyum

It appear to be reporting at least some code as Covered on main
https://app.codecov.io/gh/maplibre/maplibre-gl-js/blob/main/src%2Fdata%2Ffeature_position_map.ts

And uncovered in this PR
https://app.codecov.io/gh/maplibre/maplibre-gl-js/pull/5092/blob/src/data/feature_position_map.ts

Despite being identical

[HarelM]

The report comment is saying that there is a missing uploaded file (8 files instead of 9).
I'm rerunning the CI now, see if it will help.

[HarelM]

@NathanMOlson can you address the last code review comment so I can merge this and release a new version?

[HarelM]

We have recently updated the coverage reporter, I hope it's accurate, if so, the tests need to cover more of the new code.

[NathanMOlson]

We have recently updated the coverage reporter, I hope it's accurate, if so, the tests need to cover more of the new code.

I don't think the coverage reporter is accurate. I believe the new code has 100% coverage.

[HarelM]

Thanks!!

[HarelM]

Coverage seems to work correctly (hopefully).