Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sc 8661 maple js configure loanv4 contracts #46

Merged
merged 3 commits into from
Sep 16, 2022
Merged

Sc 8661 maple js configure loanv4 contracts #46

merged 3 commits into from
Sep 16, 2022

Conversation

Jakkc
Copy link
Contributor

@Jakkc Jakkc commented Sep 15, 2022

Type Ticket
Feature Link

Problem

  • Configure SDK for LoanV4 contracts

Solution

  • Add temporary zero addresses so webapp can use new contracts with MapleAddressMapping
  • Export correct types for LoanV4 contracts

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #8661: [maple-js] Configure LoanV4 contracts.

@Jakkc Jakkc marked this pull request as ready for review September 15, 2022 11:08
@michaelsmueller michaelsmueller self-requested a review September 16, 2022 11:20
@michaelsmueller michaelsmueller merged commit 0b048fe into main Sep 16, 2022
@michaelsmueller michaelsmueller deleted the sc-8661-maple-js-configure-loanv4-contracts branch September 16, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelsmueller michaelsmueller michaelsmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jakkc @michaelsmueller