Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add airdrop addresses #29

Merged
merged 4 commits into from
Jul 28, 2022
Merged

Add airdrop addresses #29

merged 4 commits into from
Jul 28, 2022

Conversation

callum-hyland
Copy link
Contributor

@callum-hyland callum-hyland commented Jul 28, 2022 •
edited
Loading

Problem

The subgraph needs network-specific address for the airdrop, which has to come via the SDK (for non-localhost)

Solution

Add the addresses

  • mainnet
  • rinkeby
  • goerli
  • kovan

@callum-hyland callum-hyland marked this pull request as ready for review July 28, 2022 10:57
@callum-hyland callum-hyland requested a review from a team July 28, 2022 10:57
@callum-hyland callum-hyland changed the title Add mainnet + rinkeby addresses Add airdrop addresses Jul 28, 2022
michaelsmueller
michaelsmueller approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@michaelsmueller michaelsmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elegant

@callum-hyland callum-hyland merged commit 3721fba into main Jul 28, 2022
@callum-hyland callum-hyland deleted the chore/airdrop-addresses branch July 28, 2022 13:03
@michaelsmueller michaelsmueller mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jakkc Jakkc Jakkc approved these changes

@michaelsmueller michaelsmueller michaelsmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@callum-hyland @michaelsmueller @Jakkc