Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sc-7603-maple-js-mapleaddressmapping-using-weth-instead #24

Merged
merged 1 commit into from
Jul 19, 2022
Merged

sc-7603-maple-js-mapleaddressmapping-using-weth-instead #24

merged 1 commit into from
Jul 19, 2022

Conversation

Jakkc
Copy link
Contributor

@Jakkc Jakkc commented Jul 19, 2022 •
edited
Loading

Type Ticket
Bug Link

Problem

  • SDK exporting weth address under WETH rather than WETH9. Webapp errors out trying to find WETH artifacts.

Solution

  • Change to correct value

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #7603: [maple-js] MapleAddressMapping using WETH instead of WETH9.

callum-hyland
callum-hyland approved these changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@callum-hyland callum-hyland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I guess we're committing to WETH9 everywhere 🌐

@michaelsmueller michaelsmueller merged commit c2f1928 into main Jul 19, 2022
@michaelsmueller michaelsmueller deleted the sc-7603-maple-js-mapleaddressmapping-using-weth-instead branch July 19, 2022 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriamarti adriamarti adriamarti approved these changes

@callum-hyland callum-hyland callum-hyland approved these changes

@michaelsmueller michaelsmueller michaelsmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jakkc @michaelsmueller @callum-hyland @adriamarti