Sc 4728 maple js add address constants to the repo #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #4728: [maple-js] Add address constants to the repo. |
| UniswapV2Router02: '0x1111111111111111111111111111111111111111', | ||
| Util: '0x4c729887C6538485B32A63c6Eb29feBC7a5A5656', | ||
| WBTC: '0xDEd32223ceDcf3f4655D36ed829Baeb1d916510e', | ||
| WETH: '0xbd7d6a9d4520E611113AaE5CddF3f1AC1ceCffD8', |
There was a problem hiding this comment.
Note in deploy, subgraph and webapp there has some confusion in naming between WETH vs. WETH9
This led to the withdrawal bug (where Apollo couldn't post collateral) so we should probably decide and standardize
There was a problem hiding this comment.
yes, this WETH9 has been a real bother. I would say we go with WETH everywhere.
Jakkc
previously approved these changes
May 12, 2022
michaelsmueller
requested changes
May 12, 2022
michaelsmueller
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a local artifacts folder with addresses and a script that generates addresses for export from the main package. The addresses for all networks is exported from the sdk as an
addressesobject.