Map Image PDF Export #495
Merged
Map Image PDF Export #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
reviewed
Jan 25, 2017
| @@ -24,6 +24,8 @@ | |||
| p:fileSuffix="jpeg" p:contentType="image/jpeg"/> | |||
| <bean id="tiffMapOutputFormat" class="org.mapfish.print.output.MapExportOutputFormat" scope="prototype" | |||
| p:fileSuffix="tiff" p:contentType="image/tiff"/> | |||
| <bean id="tifMapOutputFormat" class="org.mapfish.print.output.MapExportOutputFormat" scope="prototype" | |||
| <bean id="tifMapOutputFormat" class="org.mapfish.print.output.MapExportOutputFormat" scope="prototype" | |||
72b9125 to
f3b6d43
Compare
|
Sorry but I don't understand the goal of this pull request ... |
sbrunner
approved these changes
Jan 27, 2017
|
In the meantime, there seems to be a conflict with more recent changes. |
f3b6d43 to
cfa257b
Compare
pvalsecc
reviewed
Mar 6, 2017
| Graphics g = pdfCB.createGraphics(width, height); | ||
| drawGraphics(width, height, graphics, g); | ||
| g.dispose(); | ||
| document.close(); |
There was a problem hiding this comment.
Those two belong to a finally.
There was a problem hiding this comment.
Made the change
pvalsecc
approved these changes
Mar 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.