proposed 3.0 changes #89
Conversation
|
I think we should also reformat it to use 4 space tabs, otherwise the diffs are harder to read due to wrapping, but we should do it after we agree on the new structure. |
3.0/vector_tile.proto
Outdated
| // to make it easier to compare with the previous version | ||
|
|
||
| // A list of key-value pairs. Just like Feature's "tags", the repeated pairs | ||
| // of integers point to Layer's "keys" (1st int) and "values" (2nd int) array. |
There was a problem hiding this comment.
Can we change "1st int" to "odd integers" and "2nd int" to "even integers"?
We should add a note that it's invalid to specify indices that are greater than or equal to the currently parsed index to explicitly disallow circular structures. Parsers are going to implement it that way in order to prevent circular structures.
There was a problem hiding this comment.
@kkaefer I fixed the odd/even (sorry i missed your comments earlier). Where/how would you like the note to be added?
3.0/vector_tile.proto
Outdated
| repeated uint32 object_value = 8 [ packed = true ]; | ||
|
|
||
| // An array of values. Similar to Feature's "tags", each integer represents | ||
| // an index of the Layer's "values" array. |
There was a problem hiding this comment.
Same note about index < current.
|
The version 3 spec will support values of type list or map. But a different encoding is used than in this PR. Closing. |
re-posting PR against the v3