Changes for advanced attributes. #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you be more specific about what's different about this than the latest version of #121? I see the "must not" for continuing to use |
e-n-f
added a commit
to mapbox/tippecanoe
that referenced
this pull request
Sep 4, 2018
e-n-f
added a commit
to mapbox/tippecanoe
that referenced
this pull request
Sep 4, 2018
2d46cc2 to
9f88bee
Compare
…gValues as a concept
|
@ericfischer @joto I updated this to have both inline and legacy attributes as an option. I think we should likely update the example as well to support both inline and legacy attributes in section 4.5. In section 4.4.2.1 do we need more detailed wording around complex values? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #121.