Adjust ImageDownloaderTests to use a new instance each time #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f940411 to
e6ce1a5
Compare
1ec5
approved these changes
Apr 26, 2018
| @@ -39,7 +40,7 @@ class ImageDownloaderTests: XCTestCase { | |||
| var errorReturned: Error? | |||
| let semaphore = DispatchSemaphore(value: 0) | |||
|
|
|||
| downloader.downloadImage(with: imageURL) { (image, data, error) in | |||
| downloader?.downloadImage(with: imageURL) { (image, data, error) in | |||
There was a problem hiding this comment.
Should this test assert that downloader is non-nil, as the other tests do below?
There was a problem hiding this comment.
I guess I was being terse since this method only touches it once. Preference was for a runtime failure (nil) vs a crash (unexpected failure unwrapping).
Happy to make it consistent with the other methods before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing this statefulness (the
lazy var) should make sense here; we're registering & unregistering theURLProtocolsubclass in a loop while the URL loading system may be doing other work. I'm hopeful this will help with the test instabilities noted in #1327 and elsewhere.I also noticed that the
ImageDownloader'sOperationQueue'smaxConcurrentOperationCountwas set semi-arbitrarily, so I removed it. This defaults the configuration toNSOperationQueueDefaultMaxConcurrentOperationCount. We could also consider setting it to2.