Change [implementation]: false to skipped: { [implementation]: 'reaso…

…n' } Closes #176
mapbox · Nov 29, 2016 · d8eba28 · d8eba28
1 parent d5f17f2
commit d8eba28
Show file tree

Hide file tree

Showing 81 changed files with 313 additions and 134 deletions.
diff --git a/lib/harness.js b/lib/harness.js
@@ -59,8 +59,10 @@ module.exports = function (directory, implementation, options, run) {
                 return;
             }
 
-            if (params[implementation] === false) {
-                console.log(colors.gray('* skipped ' + params.group + ' ' + params.test));
+            var skipped = params.skipped && params.skipped[implementation]
+            if (skipped) {
+                console.log(colors.gray('* skipped ' + params.group + ' ' + params.test +
+                    ' (' + skipped + ')'));
                 return;
             }
 

diff --git a/query-tests/world-wrapping/box/style.json b/query-tests/world-wrapping/box/style.json
@@ -2,7 +2,9 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
+      "skipped": {
+        "native": "needs issue"
+      },
       "width": 2000,
       "height": 500,
       "pixelRatio": 0.25,

diff --git a/query-tests/world-wrapping/point/style.json b/query-tests/world-wrapping/point/style.json
@@ -2,7 +2,9 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
+      "skipped": {
+        "native": "needs issue"
+      },
       "debug": true,
       "width": 1000,
       "height": 250,

diff --git a/render-tests/image/default/style.json b/render-tests/image/default/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [

diff --git a/render-tests/image/raster-brightness/style.json b/render-tests/image/raster-brightness/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [

diff --git a/render-tests/image/raster-contrast/style.json b/render-tests/image/raster-contrast/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [

diff --git a/render-tests/image/raster-hue-rotate/style.json b/render-tests/image/raster-hue-rotate/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [

diff --git a/render-tests/image/raster-opacity/style.json b/render-tests/image/raster-opacity/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [

diff --git a/render-tests/image/raster-saturation/style.json b/render-tests/image/raster-saturation/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [

diff --git a/render-tests/image/raster-visibility/style.json b/render-tests/image/raster-visibility/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [

diff --git a/render-tests/regressions/mapbox-gl-js#3010/style.json b/render-tests/regressions/mapbox-gl-js#3010/style.json
@@ -2,12 +2,14 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/601"
       },
       "width": 512,
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "center": [
@@ -49,4 +51,4 @@
       }
     }
   ]
-}
+}
diff --git a/render-tests/regressions/mapbox-gl-js#3548/style.json b/render-tests/regressions/mapbox-gl-js#3548/style.json
@@ -2,11 +2,13 @@
   "version": 8,
   "metadata": {
     "test": {
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/4860"
       },
-      "height": 512
+      "height": 512,
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "sources": {
@@ -20,13 +22,30 @@
             "properties": {},
             "geometry": {
               "type": "Polygon",
-              "coordinates": [[
-                [ -0.0004, -0.0004 ],
-                [ -0.0004, 0.0000 ],
-                [ 0.0004, 0.0004 ],
-                [ 0.0004, -0.0000 ],
-                [ -0.0004, -0.0004 ]
-              ]]
+              "coordinates": [
+                [
+                  [
+                    -0.0004,
+                    -0.0004
+                  ],
+                  [
+                    -0.0004,
+                    0
+                  ],
+                  [
+                    0.0004,
+                    0.0004
+                  ],
+                  [
+                    0.0004,
+                    0
+                  ],
+                  [
+                    -0.0004,
+                    -0.0004
+                  ]
+                ]
+              ]
             }
           }
         ]
@@ -168,4 +187,4 @@
       }
     }
   ]
-}
+}
diff --git a/...r-tests/runtime-styling/layout-property-default-to-property-function/style.json b/...r-tests/runtime-styling/layout-property-default-to-property-function/style.json
@@ -4,7 +4,6 @@
     "test": {
       "width": 64,
       "height": 64,
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/4860 https://github.com/mapbox/mapbox-gl-native/issues/6518"
       },
@@ -21,7 +20,10 @@
         [
           "wait"
         ]
-      ]
+      ],
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "transition": {
@@ -74,4 +76,4 @@
       }
     }
   ]
-}
+}
diff --git a/...r-tests/runtime-styling/layout-property-literal-to-property-function/style.json b/...r-tests/runtime-styling/layout-property-literal-to-property-function/style.json
@@ -4,7 +4,6 @@
     "test": {
       "width": 64,
       "height": 64,
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/4860 https://github.com/mapbox/mapbox-gl-native/issues/6518"
       },
@@ -21,7 +20,10 @@
         [
           "wait"
         ]
-      ]
+      ],
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "transition": {
@@ -75,4 +77,4 @@
       }
     }
   ]
-}
+}
diff --git a/...r-tests/runtime-styling/layout-property-property-function-to-default/style.json b/...r-tests/runtime-styling/layout-property-property-function-to-default/style.json
@@ -4,7 +4,6 @@
     "test": {
       "width": 64,
       "height": 64,
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/4860 https://github.com/mapbox/mapbox-gl-native/issues/6518"
       },
@@ -18,7 +17,10 @@
         [
           "wait"
         ]
-      ]
+      ],
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "transition": {
@@ -75,4 +77,4 @@
       }
     }
   ]
-}
+}
diff --git a/...r-tests/runtime-styling/layout-property-property-function-to-literal/style.json b/...r-tests/runtime-styling/layout-property-property-function-to-literal/style.json
@@ -4,7 +4,6 @@
     "test": {
       "width": 64,
       "height": 64,
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/4860 https://github.com/mapbox/mapbox-gl-native/issues/6518"
       },
@@ -18,7 +17,10 @@
         [
           "wait"
         ]
-      ]
+      ],
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "transition": {
@@ -75,4 +77,4 @@
       }
     }
   ]
-}
+}
diff --git a/...er-tests/runtime-styling/paint-property-default-to-property-function/style.json b/...er-tests/runtime-styling/paint-property-default-to-property-function/style.json
@@ -4,7 +4,6 @@
     "test": {
       "width": 64,
       "height": 64,
-      "native": false,
       "ignored": {
         "native": "https://github.com/mapbox/mapbox-gl-native/issues/4860 https://github.com/mapbox/mapbox-gl-native/issues/6518"
       },
@@ -21,7 +20,10 @@
         [
           "wait"
         ]
-      ]
+      ],
+      "skipped": {
+        "native": "needs issue"
+      }
     }
   },
   "transition": {
@@ -70,4 +72,4 @@
       "source": "geojson"
     }
   ]
-}
+}