Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Rename text-field to text #646

Closed
1ec5 opened this issue Jan 5, 2017 · 2 comments
Closed

Rename text-field to text #646

1ec5 opened this issue Jan 5, 2017 · 2 comments

Comments

@1ec5
Copy link
Contributor

1ec5 commented Jan 5, 2017

The text-field property should be renamed to simply text.

The name text-field makes it sound like the property was originally intended to identify a field in the feature’s properties object. That happens to be what this property is usually used for, but by that logic we’d have icon-image-field instead of icon-image. Given the enthusiasm for supporting more expressive values for this property in #104 and #47, the word “field” feels downright anachronistic.

The name text-field is also misleading when incorporated into the iOS and macOS SDKs: the developer would expect a textField property to hold an NSTextField or UITextField, or at least some kind of editable control, but not an NSString. There is such a thing as NSText on macOS, but no one ever uses it directly. On the other hand, UILabel.text, analogous to the text-field layout property, is one of the most commonly used properties on iOS.

/cc @lucaswoj @jfirebaugh

@lucaswoj
Copy link

lucaswoj commented Jan 5, 2017

This fits nicely with #218

@lucaswoj
Copy link

lucaswoj commented Feb 1, 2017

This issue was moved to mapbox/mapbox-gl-js#4166

@lucaswoj lucaswoj closed this as completed Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants