Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

Drop prefixes in property names #218

Closed
peterqliu opened this issue Nov 17, 2014 · 4 comments
Closed

Drop prefixes in property names #218

peterqliu opened this issue Nov 17, 2014 · 4 comments

Comments

@peterqliu
Copy link
Contributor

peterqliu commented Nov 17, 2014

screen shot 2014-11-17 at 12 29 46 pm

Namely, fill-,line-,raster-,background-

These prefixes automatically take after the layer's type, and as long as they live on separate layers, are redundant. The other prefixes icon- and text- are necessary, since they can cohabit the same symbol layer.

@jfirebaugh
Copy link
Contributor

Given that we need the prefix for symbol properties, and we might want to use them for a combination stroked and filled "polygon" type layer as well, I think we should keep them universal.

@jfirebaugh
Copy link
Contributor

Keeping these for now.

@lucaswoj lucaswoj reopened this Dec 21, 2016
@1ec5
Copy link
Contributor

1ec5 commented Dec 21, 2016

Dropping the redundant prefixes would be highly desirable for the iOS and macOS SDKs, where property names are expected to be grammatical: mapbox/mapbox-gl-native#6577 (comment). As of mapbox/mapbox-gl-native#7457, we have to twist the English language in weird ways to ensure that Boolean property names in particular use the right parts of speech.

@lucaswoj
Copy link

lucaswoj commented Feb 1, 2017

This issue was moved to mapbox/mapbox-gl-js#4083

@lucaswoj lucaswoj closed this as completed Feb 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants