Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Update SMCalloutView to fix iOS 10 build warnings (redux) #9314

Merged
merged 1 commit into from
Jun 21, 2017
Merged

Update SMCalloutView to fix iOS 10 build warnings (redux) #9314

merged 1 commit into from
Jun 21, 2017

Conversation

1ec5
Copy link
Contributor

@1ec5 1ec5 commented Jun 21, 2017

Reapplied #6619, which was partially rolled back in #8431, to bring back the fix in nfarina/calloutview#107.

/cc @lbud @friedbunny

@1ec5
[ios] Update SMCalloutView to fix iOS 10 build warnings
2676ad0 
Reapplied 76a2a2d, which was partially rolled back in f6e79d7.
@1ec5 1ec5 added annotations Annotations on iOS and macOS or markers on Android build iOS Mapbox Maps SDK for iOS labels Jun 21, 2017
@1ec5 1ec5 self-assigned this Jun 21, 2017
@1ec5 1ec5 requested a review from friedbunny June 21, 2017 01:08
@1ec5 1ec5 mentioned this pull request Jun 21, 2017
Merged
12 tasks
friedbunny
friedbunny approved these changes Jun 21, 2017
View reviewed changes
Copy link
Contributor

@friedbunny friedbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was curious why these warnings had returned.

@1ec5 1ec5 merged commit 2676ad0 into master Jun 21, 2017
@1ec5 1ec5 deleted the 1ec5-smcalloutview-forward branch June 21, 2017 09:35
@friedbunny friedbunny mentioned this pull request Jul 13, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@friedbunny friedbunny friedbunny approved these changes

Assignees

@1ec5 1ec5

Labels
annotations Annotations on iOS and macOS or markers on Android build iOS Mapbox Maps SDK for iOS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @friedbunny