This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Integrate CMake build into Gradle + Android Studio #8363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kkaefer, thanks for your PR! By analyzing this pull request, we identified @tmpsantos, @jfirebaugh and @1ec5 to be potential reviewers. |
99a9033 to
1cf44c0
Compare
|
I have taken this PR for a spin and is looking great: Compiling c++ code as part of the build:
Using LLDB debugger directly in IDE with breakpoint support:
|
aadcd2c to
42cc60a
Compare
ivovandongen
approved these changes
Mar 14, 2017
jfirebaugh
reviewed
Mar 14, 2017
platform/android/config.cmake
Outdated
| @@ -250,11 +250,6 @@ target_link_libraries(mapbox-gl | |||
| PUBLIC -Wl,--gc-sections | |||
| ) | |||
|
|
|||
| # Create a stripped version of the library and copy it to the JNIDIR. | |||
There was a problem hiding this comment.
Does this still happen somewhere else? Do we need to update metrics.sh?
There was a problem hiding this comment.
before:
200,816,848 bytes: build/android-arm-v8-21/Release/libmapbox-gl.so
5,510,144 bytes: platform/android/MapboxGLAndroidSDK/src/main/jniLibs/arm64-v8a/libmapbox-gl.so
after:
201,035,760 bytes: platform/android/MapboxGLAndroidSDK/build/intermediates/cmake/release/obj/arm64-v8a/libmapbox-gl.so
5,510,144 bytes: platform/android/MapboxGLAndroidSDK/build/intermediates/bundles/default/jni/arm64-v8a/libmapbox-gl.so
The Gradle build automatically strips the symbols before putting them into the APK.
Given that the output path is now different, I also updated metrics.sh.
42cc60a to
05baea5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.