This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Add functions for numeric layout properties #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@lbud Can you rebase this on |
| void TileParser::parse() { | ||
| parseStyleLayers(style->layers); | ||
| void TileParser::parse(float z) { | ||
| parseStyleLayers(style->layers, z); |
There was a problem hiding this comment.
I think you can avoid needing to thread z through by using tile.id.z instead.
|
Trying to root out a few weird test failures here —
|
| std::string name; | ||
| util::ptr<StyleSource> style_source; | ||
| std::string source_layer; | ||
| FilterExpression filter; | ||
| ClassProperties layout; | ||
| StyleBucketRender render = std::false_type(); | ||
| float min_zoom = -std::numeric_limits<float>::infinity(); | ||
| float max_zoom = std::numeric_limits<float>::infinity(); | ||
| VisibilityType visibility = VisibilityType::Visible; |
There was a problem hiding this comment.
Is this visibility unused now that StyleBucket* all have their own visibility?
There was a problem hiding this comment.
@jfirebaugh good point — there was some trickery here since layout properties became parsed differently; about to push a fix that removes all individual StyleBucket* visibility properties.
6d36f26 to
895d904
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs mapbox/mapbox-gl-style-spec#238