This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Move SQLite logging setup to before database initialization #6296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@friedbunny, thanks for your PR! By analyzing this pull request, we identified @jfirebaugh and @artemp to be potential reviewers. |
|
👍 If you want you can move that whole static initializer expression into the namespace to avoid qualifying |
|
Moving |
- Ensure that sqlite3_config() is always called before db init. - Should only be called once, now. - Move sqliteVersionCheck into mapbox::sqlite namespace.
c942de3 to
e26fa4d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
SQLITE_MISUSEwarning on the first launch of an app — half of #6295.Follows-up on the initial SQLite logging implementation in #6291.
/cc @jfirebaugh