This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
[android] Checkstyle fixes round 1 #6234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good overall @cammace. The only trouble I ran into when running the TestApp was with
Once those are addressed this should be good to go. |
|
What's the crash your getting? For ViewPagerActivity, I was getting a crash also but it was related to #6193. clearing the apps data fixed it for me. |
|
For the the ManualZoomActivity not rendering a style, this can be reproduced in master and has to do with setting the style using the MapView object. Ticketed in #6242. Looking into the ViewPagerActivity issue now. |
|
|
|
@bleege has given the 👍 merging now cc: @mapbox/android |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removes a lot of the Hungarian notation and fixes other checkstyle issues. @bleege can you review?