Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Added sample InfoWindowConcurrentActivity #3152

Merged
merged 1 commit into from
Dec 2, 2015
Merged

Conversation

zugaldia
Copy link
Member

To illustrate the behavior of multiple InfoWindows visible at a time (#3115).

@zugaldia zugaldia added the Android Mapbox Maps SDK for Android label Nov 30, 2015
@incanus
Copy link
Contributor

incanus commented Nov 30, 2015

This as well as the Info Window tracking to pans & zooms is 👌 💯

@zugaldia
Copy link
Member Author

@incanus right. both features ended up being implemented at pretty much the same time.

@incanus
Copy link
Contributor

incanus commented Nov 30, 2015

Looking good!

anigif-1448918357

One weird manifestation of this odd UI pattern is the final frame here:

screen shot 2015-11-30 at 1 20 18 pm

Layering was done by which was above the other pre-rotation, but later rotations can throw this off.

@zugaldia
Copy link
Member Author

cc: @tobrun

@bleege bleege added this to the android-v2.3.0 milestone Nov 30, 2015
@zugaldia zugaldia force-pushed the 3151-testapp-sample branch from 32170af to c66a69e Compare November 30, 2015 21:58
@tobrun
Copy link
Member

tobrun commented Dec 1, 2015

@zugaldia
Not really sure what best UX would be in this case.. hence this is an odd ui pattern.

In general:
The parent layout is a FrameLayout so it will stack up its children in the way they were added to the ViewGroup. We could play around with this by using addView with an index or replace FrameLayout with a Relative so we can use bringToFront.

@zugaldia
Copy link
Member Author

zugaldia commented Dec 1, 2015

I have added the layering issue @incanus has found to the original ticket (#3115 (comment)) but this doesn't affect this PR, as it's just the test app and the basic functionality is there.

Also, the CI fail above is unrelated to Android, so if it all looks good otherwise, we're ready to merge the branch.

/cc: @bleege

@incanus
Copy link
Contributor

incanus commented Dec 1, 2015

hence this is an odd ui pattern

android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar" />

<com.mapbox.mapboxsdk.views.MapView
android:id="@+id/mapView"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zugaldia Let's change the id to something like @+id/infoWindowConcurrentMapView. While there shouldn't be any runtime issues due to namespacing, I unfortunately got us into the habit of using @+id/mapView in all the TestApp examples which makes immediate sight recognition more difficult than it should be.

@zugaldia
Copy link
Member Author

zugaldia commented Dec 2, 2015

@bleege sounds good, I'll include that before merging.

@zugaldia zugaldia force-pushed the 3151-testapp-sample branch from 3f5a662 to f629e34 Compare December 2, 2015 17:08
…strate the behavior of multiple InfoWindows visible at a time.
@zugaldia zugaldia force-pushed the 3151-testapp-sample branch from f629e34 to 2a0d2b7 Compare December 2, 2015 17:12
@zugaldia zugaldia merged commit 2a0d2b7 into master Dec 2, 2015
@zugaldia zugaldia deleted the 3151-testapp-sample branch December 2, 2015 17:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants