-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Added sample InfoWindowConcurrentActivity #3152
Conversation
This as well as the Info Window tracking to pans & zooms is 👌 💯 |
@incanus right. both features ended up being implemented at pretty much the same time. |
cc: @tobrun |
32170af
to
c66a69e
Compare
@zugaldia In general: |
I have added the layering issue @incanus has found to the original ticket (#3115 (comment)) but this doesn't affect this PR, as it's just the test app and the basic functionality is there. Also, the CI fail above is unrelated to Android, so if it all looks good otherwise, we're ready to merge the branch. /cc: @bleege |
android:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar" /> | ||
|
||
<com.mapbox.mapboxsdk.views.MapView | ||
android:id="@+id/mapView" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zugaldia Let's change the id to something like @+id/infoWindowConcurrentMapView
. While there shouldn't be any runtime issues due to namespacing, I unfortunately got us into the habit of using @+id/mapView
in all the TestApp examples which makes immediate sight recognition more difficult than it should be.
@bleege sounds good, I'll include that before merging. |
3f5a662
to
f629e34
Compare
…strate the behavior of multiple InfoWindows visible at a time.
f629e34
to
2a0d2b7
Compare
To illustrate the behavior of multiple InfoWindows visible at a time (#3115).