This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Upgrade OHHTTPStubs to 4.3.0 #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No more warnings, but the build still stalls. 😞 |
|
The build is stalling on |
|
I can reproduce the stall in the iPad 2 simulator. The test is waiting for Location Services authorization:
|
|
Ha-ha wow. Need an extra tap? |
This commit rolls back AliSoftware/OHHTTPStubs@806ba99 so that we can keep using OHHTTPStubs in the same project without creating a separate framework target.
6bcf2e8 to
8e8a341
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades AliSoftware/OHHTTPStubs@4.3.0 in the ios-tests project, fixing warnings we’ve been seeing such as:
and hopefully mitigating our issues with stalled iOS builds.
Note that I had to revert AliSoftware/OHHTTPStubs@806ba99 to get the test sources to compile again. In the future, we might want to move OHHTTPStubs to a separate framework target so that these source modifications aren’t necessary.
/cc @incanus @ljbade