Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Refactor MapView code to be more maintainable. Implement JavaDocs up to rotation. #2478

Merged
merged 1 commit into from
Oct 1, 2015

Conversation

ljbade
Copy link
Contributor

@ljbade ljbade commented Oct 1, 2015

This is the first of several MapView JavaDoc commits for #2002

@ljbade ljbade added Android Mapbox Maps SDK for Android documentation in progress labels Oct 1, 2015
@ljbade ljbade merged commit 4930a40 into master Oct 1, 2015
@ljbade ljbade removed the in progress label Oct 1, 2015
@ljbade
Copy link
Contributor Author

ljbade commented Oct 1, 2015

I'm going to keep the branch alive

@jfirebaugh jfirebaugh deleted the 2002-javadoc branch October 2, 2015 00:11
@bleege bleege added this to the android-v2.1.0 milestone Oct 6, 2015
@bleege
Copy link
Contributor

bleege commented Oct 6, 2015

@ljbade Can you clarify why moving the Annotation classes to the views package was necessary?

@bleege bleege mentioned this pull request Oct 6, 2015
@ljbade
Copy link
Contributor Author

ljbade commented Oct 7, 2015

@bleege This was so some public functions in MapView that are only mean for internal use by InfoWindow could be made package private.

@bleege
Copy link
Contributor

bleege commented Oct 10, 2015

@ljbade Ah... thanks for the background info. That said, it still seems to make more sense to have all the Annotations stuff in one package. I could see a developer using the SDK being confused as to why things were split up. I also know that MapView and Annotations have a tight working relationship but keeping them separate has the additional benefit of helping us build stronger APIs and codebase.

@ljbade
Copy link
Contributor Author

ljbade commented Oct 11, 2015

@bleege In #2538 I am proposing merging the annotations and views packages, perhaps just putting them under the base package. Google Maps API seems to happily keep everything in one package. Hmm they don't...

@ljbade
Copy link
Contributor Author

ljbade commented Oct 11, 2015

Actually I figure out how to fix this properly, top offset pixels should be a member of Marker that we pass in addMarker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants