Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Add font array attribute configuration #15488

Merged
merged 1 commit into from
Aug 28, 2019
Merged

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Aug 26, 2019

Follow up from #15255, this PR enables setting a StringArray resource reference and adds integration of this into MapboxMapOptions. Additionally if a user want to disable localideograph completely, they can use the newly introduced flags.

@tobrun tobrun added Android Mapbox Maps SDK for Android release blocker Blocks the next final release needs backport Indicates PR needs to be cherrypicked into a previous release branch. needs changelog Indicates PR needs a changelog entry prior to merging. labels Aug 26, 2019
@tobrun tobrun added this to the release-queso milestone Aug 26, 2019
@tobrun tobrun requested review from pengdev and LukasPaczos August 26, 2019 14:37
@tobrun tobrun self-assigned this Aug 26, 2019
@tobrun tobrun force-pushed the tvn-attr-localideograph branch from b77f5fd to b198017 Compare August 27, 2019 07:59
@tobrun tobrun removed the needs changelog Indicates PR needs a changelog entry prior to merging. label Aug 27, 2019
@tobrun tobrun force-pushed the tvn-attr-localideograph branch 2 times, most recently from dd078b3 to 68c8a40 Compare August 27, 2019 09:12
@tobrun tobrun force-pushed the tvn-attr-localideograph branch 2 times, most recently from 0101930 to 638f794 Compare August 27, 2019 12:04
@tobrun tobrun force-pushed the tvn-attr-localideograph branch 2 times, most recently from 96fa6a7 to 31a96bd Compare August 27, 2019 13:17
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@tobrun tobrun force-pushed the tvn-attr-localideograph branch 3 times, most recently from 5223aeb to 72c3a05 Compare August 27, 2019 16:58
…font, add enable flag attribute configuration
@tobrun tobrun force-pushed the tvn-attr-localideograph branch from 72c3a05 to 68c0125 Compare August 27, 2019 17:00
@tobrun tobrun merged commit 309f566 into master Aug 28, 2019
@tobrun tobrun deleted the tvn-attr-localideograph branch August 28, 2019 06:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android needs backport Indicates PR needs to be cherrypicked into a previous release branch. release blocker Blocks the next final release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants