This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Rename source classes #11568
Merged
Merged
Rename source classes #11568
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
3464bfc
[ios, macos] Renamed MGLRasterSource to MGLRasterTileSource
1ec5 0c66226
[ios, macos] Mention update-examples in contributing guide
1ec5 443d8b5
[ios, macos] Renamed MGLVectorSource to MGLVectorTileSource
1ec5 0a31713
[ios, macos] Eliminated MGLAbstractShapeSource
1ec5 e79e8e4
[ios, macos] Clarified source options
1ec5 7a9026c
[ios, macos] Corrected documentation
1ec5 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -178,21 +178,22 @@ source object is a member of one of the following subclasses of `MGLSource`: | |
|
||
In style JSON | In the SDK | ||
--------------|----------- | ||
`vector` | `MGLVectorTileSource` | ||
`raster` | `MGLRasterTileSource` | ||
`raster-dem` | `MGLRasterDEMSource` | ||
`geojson` | `MGLShapeSource` | ||
`raster` | `MGLRasterSource` | ||
`vector` | `MGLVectorSource` | ||
`image` | `MGLImageSource` | ||
|
||
`canvas` and `video` sources are not supported. | ||
|
||
### Tile sources | ||
|
||
Raster and vector sources may be defined in TileJSON configuration files. This | ||
SDK supports the properties defined in the style specification, which are a | ||
Raster and vector tile sources may be defined in TileJSON configuration files. | ||
This SDK supports the properties defined in the style specification, which are a | ||
subset of the keys defined in version 2.1.0 of the | ||
[TileJSON](https://github.com/mapbox/tilejson-spec/tree/master/2.1.0) | ||
specification. As an alternative to authoring a custom TileJSON file, you may | ||
supply various tile source options when creating a raster or vector source. | ||
supply various tile source options when creating a raster or vector tile source. | ||
These options are detailed in the `MGLTileSourceOption` documentation: | ||
|
||
In style JSON | In TileJSON | In the SDK | ||
|
@@ -401,7 +402,7 @@ For operators that have no corresponding `NSExpression` symbol, use the | |
|
||
## Filtering sources | ||
|
||
You can filter a shape or vector source by setting the | ||
You can filter a shape or vector tile source by setting the | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this include computed shape source, or is it implied with 'shape .. source' ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This document is meant as a correspondence from style JSON to the runtime styling API. Since computed shape sources can’t be represented in style JSON, I’ve omitted that type here. |
||
`MGLVectorStyleLayer.predicate` property to an `NSPredicate` object. Below is a | ||
table of style JSON operators and the corresponding operators used in the | ||
predicate format string: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be MGLRasterDemTileSource in case we decide to add a computed RasterDEM source in conjunction with computed raster/image source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think that’s at least as likely as a computed image source? If so, I think I’d push for some
mbgl::style::Source
classes to be consolidated, which would allow us to consolidate these classes at the SDK level.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't seen any requests for it. And you make a good point, core sources will probably get refactored if we get that far.