This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Unwrap coordinate bounds #11265
Merged
Unwrap coordinate bounds #11265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated coordinate bounds conversion methods to use the beyond-±180 method to indicate that the bounds extends beyond the antimeridian. Also copyedited conversion documentation.
fabian-guerra
approved these changes
Feb 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-[MGLMapView convertRect:toCoordinateBoundsFromView:]method and theMGLMapView.visibleCoordinateBoundsproperty’s getter now indicate that the coordinate bounds straddles the antimeridian by extending one side beyond ±180° longitude. This behavior is consistent with how the SDK interprets polyline and polygon coordinates. However, it represents a backwards-incompatible change, inasmuch as developers may have relied on the previous behavior of returning a bounds that starts and ends at the antimeridian.Fixes #4664.
/cc @jmkiley @fabian-guerra @brunoabinader