Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Extra space on an InfoWindow without a snippet #4959

Closed
tobrun opened this issue May 6, 2016 · 7 comments
Closed

Extra space on an InfoWindow without a snippet #4959

tobrun opened this issue May 6, 2016 · 7 comments
Assignees
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android

Comments

@tobrun
Copy link
Member

tobrun commented May 6, 2016

When you create a marker with a title but without a snippet. You will see a empty space below the title in the InfoWindow. This should be optimised to fit nicely in the InfoWindow.

Current behaviour:
image

@tobrun tobrun added bug Android Mapbox Maps SDK for Android labels May 6, 2016
@bleege bleege removed the bug label May 11, 2016
@bleege bleege added the annotations Annotations on iOS and macOS or markers on Android label Jun 7, 2016
@bleege bleege added this to the android-v4.1.0 milestone Jun 13, 2016
@bleege
Copy link
Contributor

bleege commented Jun 13, 2016

Discussed with @zugaldia @tobrun @ivovandongen @cammace this morning and we'll add this to 4.1.0 to support #5282.

@bleege bleege self-assigned this Jun 13, 2016
@bleege
Copy link
Contributor

bleege commented Jun 13, 2016

Will be working in the Standard InfoWindow Example to build this out.

device-2016-06-13-144327
Starting Point

@bleege
Copy link
Contributor

bleege commented Jun 13, 2016

Title only InfoWindow sizing....

device-2016-06-13-145240
The Ellipse Title Only Example

@bleege
Copy link
Contributor

bleege commented Jun 13, 2016

I added Sherman Park marker example to show that no InfoWindow is displayed if there's no Title nor Snippet. I added the Lafayette Square marker example to show what happens in Snippet only mode. I think it makes the most sense for the the snippet only example to render as a snippet and not be forced to render as a Title if there is no title. This provides more flexibility within the controls.

device-2016-06-13-151149
Sherman Park and Lafayette Square

bleege added a commit that referenced this issue Jun 13, 2016
@bleege
Copy link
Contributor

bleege commented Jun 13, 2016

Squash, Rebased, and Merged into release-android-v4.1.0.

@bleege bleege closed this as completed Jun 13, 2016
@tobrun
Copy link
Member Author

tobrun commented Jun 13, 2016

@bleege looks great!

@cammace
Copy link
Contributor

cammace commented Jun 13, 2016

Wooo! Thanks for hitting this 🎫 @bleege, looks much better!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android annotations Annotations on iOS and macOS or markers on Android
Projects
None yet
Development

No branches or pull requests

3 participants