Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

AddCircle method for map, support modify radius of circle #4153

Closed
Trinea opened this issue Mar 1, 2016 · 11 comments
Closed

AddCircle method for map, support modify radius of circle #4153

Trinea opened this issue Mar 1, 2016 · 11 comments
Labels
Android Mapbox Maps SDK for Android feature

Comments

@Trinea
Copy link

Trinea commented Mar 1, 2016

Like below, we need add circle on the map, so we can change the radius constantly to make a animation.

@Trinea
Copy link
Author

Trinea commented Mar 1, 2016

@jjhurlock

@jjhurlock
Copy link

@Trinea We have a UserLocationView, that implements a similar effect here

Is this helpful to start implementing this feature?

@tobrun
Copy link
Member

tobrun commented Mar 6, 2016

@jjhurlock while the SDK has a similar effect we are currently not exposing this as an API. This is something I have been thinking about in #3276. This will allow end developers to draw Android Views on a certain LatLng and give them the ability to do whatever they like with it.

Note that exposing this as an API has a history to it.. we prefer people using GL based markers because they are more performant and allow scaling. On the other hand these markers are very limited in what we can do with hem, for example having marker animation.

Update: just found this ticket with the history behind this: #3116

@tobrun tobrun added this to the android-v4.1.0 milestone Mar 6, 2016
@tobrun tobrun added the Android Mapbox Maps SDK for Android label Mar 6, 2016
@Trinea
Copy link
Author

Trinea commented Mar 7, 2016

ok, this is not urgent for us.

#4090
#3985
#4159

These are urgent for us, please process first, Thank you

@bleege bleege modified the milestone: android-v4.1.0 Mar 18, 2016
@zugaldia
Copy link
Member

Just noting that the request here, if I understand correctly, is to (1) receive an event callback while hovering over a previously added marker, in order to trigger some custom behavior (in this case, (2) an animation).

@tobrun is this something unlocked for view markers now that #3276 has landed?

@tobrun
Copy link
Member

tobrun commented Jun 10, 2016

Yes,

A user should be able to track the camera position with an OnCameraChangeListener and check if the LatLng from the camera matches the location of a Marker. If it does, the user should get a reference to the related view with mapboxMap.getViewMarkerManager().getView(markerView) and should be able to execute an animation.

@tobrun
Copy link
Member

tobrun commented Jun 14, 2016

I created some sample code on achieving this with ViewMarkers in #5346.
@bleege is running point on integrating this into the location picker example #5282.

@zugaldia
Copy link
Member

@tobrun Great, this looks fantastic.

As discussed in #5346 (comment), @bleege is picking this code up together with the MyLocationView usecase to create a new sample activity that demoes this functionality.

@Trinea good news, this will be included in the next Android 4.1 release.

@zugaldia zugaldia added this to the android-v4.1.0 milestone Jun 14, 2016
@zugaldia
Copy link
Member

Related: #2167 (comment)

@zugaldia
Copy link
Member

zugaldia commented Jun 17, 2016

Done in #5346.

@zugaldia
Copy link
Member

@Trinea good news, this is also completed, and it will be available in the next release of the SDK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android feature
Projects
None yet
Development

No branches or pull requests

6 participants