Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

After switching styles InfoWindow positions not updated #2599

Closed
ljbade opened this issue Oct 13, 2015 · 2 comments
Closed

After switching styles InfoWindow positions not updated #2599

ljbade opened this issue Oct 13, 2015 · 2 comments
Assignees
@ljbade
Labels
Android Mapbox Maps SDK for Android bug
Milestone
android-v2.1.0

Comments

@ljbade
Copy link
Contributor

ljbade commented Oct 13, 2015

After switching styles the InfoWindow positions not updated if the marker size changes.

How to reproduce:

  • add some markers
  • touch marker to open InfoWindow
  • change from Streets to Emerald

device-2015-10-13-164015
device-2015-10-13-164043
@ljbade ljbade added bug Android Mapbox Maps SDK for Android labels Oct 13, 2015
@ljbade ljbade added this to the android-v2.2.0 milestone Oct 13, 2015
@ljbade
Copy link
Contributor Author

ljbade commented Oct 13, 2015

The fix for this depends on #2263.

After a style finishes loading, we need to loop through all active Markers, update their top offset pixels values, then show/hide the InfoWindow to calculate the new position.

@ljbade ljbade mentioned this issue Oct 13, 2015
Closed
@ljbade
Copy link
Contributor Author

ljbade commented Oct 13, 2015

Should /cc @bleege @tobrun

@ljbade ljbade mentioned this issue Oct 13, 2015
Closed
@ljbade ljbade self-assigned this Oct 13, 2015
@ljbade ljbade mentioned this issue Oct 13, 2015
Merged
@ljbade ljbade modified the milestones: android-v2.1.0, android-v2.2.0 Oct 15, 2015
@ljbade ljbade mentioned this issue Oct 15, 2015
Merged
@ljbade ljbade mentioned this issue Oct 16, 2015
Closed
@ljbade ljbade closed this as completed in 2ee7b02 Oct 16, 2015
ljbade pushed a commit that referenced this issue Oct 16, 2015
@bleege
[core] [android] Fix InfoWindow topOffsetPixels adjustment when switc…
66c3fe2 
…hing styles

Fixes #2599
Make getTopOffsetPixelsForAnnotationSymbol private
Also implements MapChangeWillStartLoadingMap, MapChangeDidFinishLoadingMap
Paritally implements #630
AndwareSsj pushed a commit to AndwareSsj/mapbox-gl-native that referenced this issue Nov 6, 2015
[core] [android] Fix InfoWindow topOffsetPixels adjustment when switc…
5d00134 
…hing styles

Fixes mapbox#2599
Make getTopOffsetPixelsForAnnotationSymbol private
Also implements MapChangeWillStartLoadingMap, MapChangeDidFinishLoadingMap
Paritally implements mapbox#630
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ljbade ljbade

Labels
Android Mapbox Maps SDK for Android bug
Projects
None yet
Milestone
android-v2.1.0
Development

No branches or pull requests
1 participant
@ljbade