Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Fix root.plist flag conversion. #288

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Fix root.plist flag conversion. #288

merged 2 commits into from
Apr 30, 2020

Conversation

fabian-guerra
Copy link
Contributor

Fixes #212

@fabian-guerra fabian-guerra added bug Something isn't working skip-changelog labels Apr 29, 2020
@fabian-guerra fabian-guerra requested review from 1ec5 and a team April 29, 2020 23:50
@fabian-guerra fabian-guerra self-assigned this Apr 29, 2020
1ec5
1ec5 approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Might be worth a changelog entry, in case anyone happens to have set the default value to NO in the past and not realized that was incorrect. Better for a developer to find out before running the application.

@fabian-guerra fabian-guerra merged commit 76f58c5 into master Apr 30, 2020
@fabian-guerra fabian-guerra deleted the fabian-telemetry-optout-212 branch April 30, 2020 18:54
@fabian-guerra
Copy link
Contributor Author

I temporarily disabled ios-debug check to merge this pr. Issue tracked in #291

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees

@fabian-guerra fabian-guerra

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The logic for checking whether telemetry opt-out control is missing may contain a bug
2 participants
@fabian-guerra @1ec5