Move featuresAt ref work out of the worker/featureTree, contained in style #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (Object.keys(this.refs).length) features.forEach((feature) => { | ||
| if (this.refs[feature.layer.id] && this.refs[feature.layer.id].length) { | ||
| this.refs[feature.layer.id].forEach(refLayer => { | ||
| var copiedFeature = JSON.parse(JSON.stringify(feature)); |
There was a problem hiding this comment.
@jfirebaugh is there a less ugly way to deep clone here?
There was a problem hiding this comment.
You only need a one level deep clone right? var copiedFeature = util.extend({}, feature).
mourner
added a commit
that referenced
this pull request
Jan 19, 2015
Move featuresAt ref work out of the worker/featureTree, contained in style
|
Merging this now because of the performance regression in #901 (refs created duplicate buckets which increased tile parsing time 2x — water, buildings, etc.). This approach looks much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially reverts #901, moving the featuresAt refs work to be contained within the Style so the worker doesn't parse ref layers into the featureTree.