1.5.0-beta.1 #8879

arindam1993 · 2019-10-16T21:11:41Z

Updated CHANGELOG.md and package.version

asheemmamoowala

This seems to be missing an entry for #8868

asheemmamoowala · 2019-10-16T21:23:19Z

CHANGELOG.md

+## 🍏 Improvements
+* `icon-text-fit` now properly respects `text-writing-mode`:`vertical` ([#8835](https://github.com/mapbox/mapbox-gl-js/pull/8835))
+* GeolocateControl emits an `outofmaxbounds` and cancels the geolocate `flyTo` if the user is outside of `map.maxBounds` ([#8756](https://github.com/mapbox/mapbox-gl-js/pull/8756)) (h/t [MoradiDavijani](https://github.com/MoradiDavijani))
+* Symbol's fade faster when zooming out quickly reducing overlap. ([#8628](https://github.com/mapbox/mapbox-gl-js/pull/8628))


~~Symbol's~~Symbols

asheemmamoowala · 2019-10-16T21:27:44Z

CHANGELOG.md

+## 🐞 Bug Fixes
+
+* Fix opacity interpolation for composition expressions. ([#8818](https://github.com/mapbox/mapbox-gl-js/pull/8818))
+* Fix `styleimagemissing` compatibility issues with `image` expression. ([#8839](https://github.com/mapbox/mapbox-gl-js/pull/8839) and [#8775](https://github.com/mapbox/mapbox-gl-js/pull/8775))


This is already in the 1.4.1 patch

ahk · 2019-10-17T00:14:54Z

CHANGELOG.md

+* `icon-text-fit` now properly respects `text-writing-mode`:`vertical` ([#8835](https://github.com/mapbox/mapbox-gl-js/pull/8835))
+* GeolocateControl emits an `outofmaxbounds` and cancels the geolocate `flyTo` if the user is outside of `map.maxBounds` ([#8756](https://github.com/mapbox/mapbox-gl-js/pull/8756)) (h/t [MoradiDavijani](https://github.com/MoradiDavijani))
+* Symbols fade faster when zooming out quickly, reducing overlap. ([#8628](https://github.com/mapbox/mapbox-gl-js/pull/8628))
+* Reduce memory usage on mouseenter event in vector tile layer's with large strings. ( [#8863](https://github.com/mapbox/mapbox-gl-js/pull/8863))


Description is a symptom of the root problem, maybe instead: "Reduce memory usage for vector tiles that contain long strings in feature properties."

chloekraw

thanks @arindam1993! just a few comments

chloekraw · 2019-10-17T18:23:02Z

CHANGELOG.md

+## 1.5.0-beta.1
+
+## ✨ Features
+* GeolocateControl displays a `disabled` icon if user denies geolocation permission. [#8871](https://github.com/mapbox/mapbox-gl-js/pull/8871))


nit: preferably entries all start with a verb that indicates what we did. so in this case, perhaps: "Add disabled icon to GeolocateControl if user denies geolocation permission."

Also what makes this change in the "Features" section but the other change to GeolocateControl in the "Improvements" section? I'm having a hard time distinguishing between the two sections 🤔

I moved it into the Features section, that does make more sense.

chloekraw · 2019-10-17T18:23:32Z

CHANGELOG.md

+
+## ✨ Features
+* GeolocateControl displays a `disabled` icon if user denies geolocation permission. [#8871](https://github.com/mapbox/mapbox-gl-js/pull/8871))
+* Add `mapboxgl.getRTLTextPluginStatus()` to query the current status of the `rtl-text-plugin` ([#8864](https://github.com/mapbox/mapbox-gl-js/pull/8864))


what benefit does this provide for the customer? what can I do now with the RTL text plugin that I couldn't do before?

Rephrased, and referenced the issue as well.

chloekraw · 2019-10-17T18:23:56Z

CHANGELOG.md

+## ✨ Features
+* GeolocateControl displays a `disabled` icon if user denies geolocation permission. [#8871](https://github.com/mapbox/mapbox-gl-js/pull/8871))
+* Add `mapboxgl.getRTLTextPluginStatus()` to query the current status of the `rtl-text-plugin` ([#8864](https://github.com/mapbox/mapbox-gl-js/pull/8864))
+* `hash` Map option can now be set as a string which sets the map hash to a custom query parameter. ([#8603](https://github.com/mapbox/mapbox-gl-js/pull/8603)) (h/t [SebCorbin](https://github.com/SebCorbin))


nit: remove "now", it's unnecessary

chloekraw · 2019-10-17T18:26:25Z

CHANGELOG.md

+
+* Fix opacity interpolation for composition expressions. ([#8818](https://github.com/mapbox/mapbox-gl-js/pull/8818))
+* Fix rotate and pitch events being fired at the same time. ([#8872](https://github.com/mapbox/mapbox-gl-js/pull/8872))
+* Fix memory leaks w.r.t tile loading and map removal.([#8813](https://github.com/mapbox/mapbox-gl-js/pull/8813) and [#8850](https://github.com/mapbox/mapbox-gl-js/pull/8850))


nit: I think it's less confusing, esp to a global audience, to avoid using abbreviations like w.r.t.

How is "Fix memory leaks in tile loading and map removal." ?

chloekraw · 2019-10-17T18:28:45Z

CHANGELOG.md

+* GeolocateControl emits an `outofmaxbounds` and cancels the geolocate `flyTo` if the user is outside of `map.maxBounds` ([#8756](https://github.com/mapbox/mapbox-gl-js/pull/8756)) (h/t [MoradiDavijani](https://github.com/MoradiDavijani))
+* Symbols fade faster when zooming out quickly, reducing overlap. ([#8628](https://github.com/mapbox/mapbox-gl-js/pull/8628))
+* Reduce memory usage for vector tiles that contain long strings in feature properties. ( [#8863](https://github.com/mapbox/mapbox-gl-js/pull/8863))
+* Improved icon density for `text-variable-anchor` by trying additional placements when icon gets collided out. ([#8803](https://github.com/mapbox/mapbox-gl-js/pull/8803))


hmm, just from reading this changelog entry, I'm a bit confused what the change was in this release because this entry seems to describe the intention of the variable label placement feature.

The change is in the icon part, we wouldn't try additional placements if the icon associated with the text got collided out, I made the description a bit clearer.

Got it. Reading your updated entry, I also think it's more of a bug fix, as when we release new style spec properties i.e. text-variable-anchor, the expectation is that they work with all existing properties i.e. icon-text-fit. (aside: In retrospect, maybe symbol-variable-anchor would have been a better name rather than text-variable-anchor if this property affects icons too.. 💭 )

I might rephrase as:

Fix text-variable-anchor not trying multiple placements during collision detection for icons when icon-text-fit is enabled.

chloekraw · 2019-10-17T18:31:59Z

CHANGELOG.md

+* `hash` Map option can now be set as a string which sets the map hash to a custom query parameter. ([#8603](https://github.com/mapbox/mapbox-gl-js/pull/8603)) (h/t [SebCorbin](https://github.com/SebCorbin))
+
+## 🍏 Improvements
+* `icon-text-fit` now properly respects `text-writing-mode`:`vertical` ([#8835](https://github.com/mapbox/mapbox-gl-js/pull/8835))


nit: not really sure if there's a rule here, but I have a slight preference for "Add support for icon-text-fit with vertical labels."

Also I'm thinking whether this is an improvement or bug fix...?

Tis a bug fix

chloekraw · 2019-10-17T18:33:05Z

CHANGELOG.md

+## 🍏 Improvements
+* `icon-text-fit` now properly respects `text-writing-mode`:`vertical` ([#8835](https://github.com/mapbox/mapbox-gl-js/pull/8835))
+* GeolocateControl emits an `outofmaxbounds` and cancels the geolocate `flyTo` if the user is outside of `map.maxBounds` ([#8756](https://github.com/mapbox/mapbox-gl-js/pull/8756)) (h/t [MoradiDavijani](https://github.com/MoradiDavijani))
+* Symbols fade faster when zooming out quickly, reducing overlap. ([#8628](https://github.com/mapbox/mapbox-gl-js/pull/8628))


nit: if we want to preserve consistency in starting with a verb, "Fade symbols faster..."

Arindam Bose added 2 commits October 16, 2019 13:49

Add changelog for gl js repo

8f3c6c6

Set appropriate package version

b0b1331

asheemmamoowala reviewed Oct 16, 2019

View reviewed changes

Cleanup and add #8868.

72261b9

ahk reviewed Oct 17, 2019

View reviewed changes

Update description for #8863

ba71da9

ryanhamley approved these changes Oct 17, 2019

View reviewed changes

chloekraw reviewed Oct 17, 2019

View reviewed changes

Arindam Bose added 2 commits October 17, 2019 12:54

Address comments, change language to use verbs.

fc28897

Move text-variable-anchor text to bug-fix section

a7efd4d

arindam1993 merged commit 48d1b92 into release-sangria Oct 17, 2019

arindam1993 deleted the 1.5.0-beta.1 branch October 17, 2019 20:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1.5.0-beta.1 #8879

1.5.0-beta.1 #8879

arindam1993 commented Oct 16, 2019

asheemmamoowala left a comment

asheemmamoowala Oct 16, 2019

asheemmamoowala Oct 16, 2019

ahk Oct 17, 2019

chloekraw left a comment

chloekraw Oct 17, 2019

chloekraw Oct 17, 2019

arindam1993 Oct 17, 2019

chloekraw Oct 17, 2019

arindam1993 Oct 17, 2019

chloekraw Oct 17, 2019

chloekraw Oct 17, 2019

chloekraw Oct 17, 2019

arindam1993 Oct 17, 2019

chloekraw Oct 17, 2019

chloekraw Oct 17, 2019

arindam1993 Oct 17, 2019

chloekraw Oct 17, 2019

1.5.0-beta.1 #8879

1.5.0-beta.1 #8879

Conversation

arindam1993 commented Oct 16, 2019

asheemmamoowala left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chloekraw left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment