Render tests for icon-text-fit combined with text-variable-anchor and text-writing-mode #8625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c164cee to
1639625
Compare
ansis
approved these changes
Aug 14, 2019
|
@ansis what do you think about updated tests with 1px border diff? Also, since the collision box for a icon-text-fit icon has proper size (bigger), it affects symbols with line placement (#4861), therefore, I've updated one line placement test. If you think these changes are acceptable and I can proceed with mapbox/mapbox-gl-native#15367, we can land new render tests and I will continue to work with native PR tomorrow. |
|
I checked with Saman and he thinks this should be ok from the map design side! Seems ok to me as well. |
In quads.js (quads.cpp) 1px quad padding is added before quad is resized for icon-text-fit property. If 1px padding is added after icon is stretched over the text box, we get 1px border. This change addresses 1px rendering difference and updates failing render tests.
bc31ba1 to
d93fcd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render tests required for mapbox/mapbox-gl-native#15367 and #8583