adjust empty string fix to match -native #6209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
commented
Feb 21, 2018
| @@ -170,6 +167,11 @@ class Placement { | |||
| offscreen = offscreen && placedIconBoxes.offscreen; | |||
| } | |||
|
|
|||
| const hasTextData = Boolean(symbolInstance.collisionArrays.textBox || symbolInstance.collisionArrays.textCircles); | |||
| const hasIconData = Boolean(symbolInstance.collisionArrays && symbolInstance.collisionArrays.iconBox); | |||
There was a problem hiding this comment.
The symbolInstance.collisionArrays && was needed to satisfy flow complaining about symbolInstance.collisionArrays being possible undefined. I'm not sure why flow didn't complain for the line above.
|
@ChrisLoer looks like this might have gotten lost in notifications — can you revisit? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should not change behaviour. This just brings -js slightly closer to the -native fix: mapbox/mapbox-gl-native#11206
benchmarks:
The benchmarks looked good except for Layout. But I wasn't able to reproduce the that difference on later runs.
Launch Checklist