Prune unused layers from the CrossTileSymbolIndex #6016
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #5995 (index leaked removed layers).
I don't think #5995 was a very big deal, but I just wanted to get this loose end out of the way. There are two changes here:
CrossTileSymbolIndex
crossTileIDs
from previously indexed versions of the layer. I don't think this change matters, because (a) crossTileIDs are always contained to one layer, and the entire layer was removed, so (b) there's no existing fade/collision state that's going to get copied over because you're using old IDs vs new IDs.I added a basic unit test for the remove process and manually tested removing a layer from an active map and then adding it back.
/cc @ansis @mollymerp