Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate container option #5635

Closed
wants to merge 1 commit into from
Closed

Validate container option #5635

wants to merge 1 commit into from

Conversation

jingsam
Copy link
Contributor

@jingsam jingsam commented Nov 9, 2017

fix #5619

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@jingsam
Copy link
Contributor Author

jingsam commented Nov 9, 2017

Ops, seems need to expose HTMLElement in util/window.js

@jfirebaugh
Copy link
Contributor

Thanks @jingsam. Can you resolve the CI failure?

@jingsam
Copy link
Contributor Author

jingsam commented Nov 16, 2017

I need to export HTMLElement in util/window.js, but I have not figure out how to do it.

@jfirebaugh
Copy link
Contributor

Add HTMLElement: typeof HTMLElement here:

mapbox-gl-js/flow-typed/window.js

Line 117 in 3a8ef5b

HTMLImageElement: typeof HTMLImageElement;

@jingsam jingsam mentioned this pull request Nov 17, 2017
Merged
@jingsam
Copy link
Contributor Author

jingsam commented Nov 17, 2017

Use #5695 instead

@jfirebaugh jfirebaugh closed this Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to check if container option is provided
2 participants
@jingsam @jfirebaugh