-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "placeholder-loading-*" properties #3694
Conversation
This would be useful for vector sources as well. Can we make it more general, taking into account the ideas in mapbox/mapbox-gl-style-spec#219? |
I see the value in making this it's own layer type. That would give developers the ability to use this feature with vector tiles and control the z-ordering of the loading pattern. Glomming this onto the |
3a5e73d
to
b80e66a
Compare
The latest commit adds a new layer type called Open to other naming ideas that convey a layer which displays source metadata, anticipating the need for |
b80e66a
to
d220459
Compare
d220459
to
15611ff
Compare
Updated to put the functionality on a new layer type called
Thoughts @jfirebaugh? |
ping @jfirebaugh @lbud I'm thinking about redoing the style spec such that it consists of
This will simplify the API and give users more control over layering order |
Gonna take this back to the drawing board somewhat 😄 |
Play with the demo!
This PR allows developers to show a pattern or color in lieu of a still-loading raster tile.
placeholder-loading-color
placeholder-loading-pattern
placeholder-loading-opacity
This feature is useful when loading raster tiles that use transparency to represent "no data." In the image below 👇 is there really no storm over SF? Or has the tile not loaded? Or has the tile errored?
In some industries, there is a regulatory requirement that a pattern be shown to disambiuate between "no data", "data loading", and "data errored"
cc @lbud @jfirebaugh @mourner
fixes #3280
Launch Checklist