Ensure images always fade in completely, fix broken "raster-fade-duration" property #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Nov 3, 2016
| @@ -156,6 +156,8 @@ class ImageSource extends Evented { | |||
| gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MIN_FILTER, gl.LINEAR); | |||
| gl.texParameteri(gl.TEXTURE_2D, gl.TEXTURE_MAG_FILTER, gl.LINEAR); | |||
| gl.texImage2D(gl.TEXTURE_2D, 0, gl.RGBA, gl.RGBA, gl.UNSIGNED_BYTE, image); | |||
| this.map.animationLoop.set(this.tile.timeAdded + this.map.style.rasterFadeDuration - Date.now()); | |||
There was a problem hiding this comment.
Why did animation loop work for raster fades before adding this line? Do we set the loop in several places for this?
4647c8c to
da7add6
Compare
|
Because of the # of failing tests and the additional workload of safely deprecating this feature, I have decided to change direction and fix our support for |
mourner
approved these changes
Nov 3, 2016
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #3526 , Mapbox GL JS does not properly implement
raster-fade-duration. This PR fully removes support for "raster-fade-duration" and thereby ensures that images always fade in completely.cc @jfirebaugh @mollymerp @mourner @mapsam
Launch Checklist
write tests for all new functionalitywe do not have any infrastructure to test animations