Optimize drawing solid backgrounds #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansis
approved these changes
Nov 3, 2016
| @@ -6,14 +6,16 @@ module.exports = drawBackground; | |||
|
|
|||
| function drawBackground(painter, sourceCache, layer) { | |||
| const gl = painter.gl; | |||
| const transform = painter.transform; | |||
| const tileSize = transform.tileSize; | |||
| const color = layer.paint['background-color']; | |||
| const image = layer.paint['background-pattern']; | |||
| const opacity = layer.paint['background-opacity']; | |||
|
|
|||
| if (painter.isOpaquePass !== (!image && color[3] === 1)) return; | |||
There was a problem hiding this comment.
This is not related to your changes, but it looks like this doesn't consider opacity when it should. If it's convenient it would nice to squeeze that in here
There was a problem hiding this comment.
Whoa, you're right! Fixing this also fixes #2925 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2773, closes #2925. There seems to be no FPS difference for me, but it might help on devices with weaker GPUs (e.g. phones).
👀 @ansis @brunoabinader