Program configuration optimizations #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jfirebaugh oops, nope, the two render tests for switching paint from default to property function are failing. Investigating. |
e9613dd to
d47dfcc
Compare
|
OK fixed the bug and rebased, merging on green. |
|
For the record, before both PRs: 9.6 ms, 5% > 16ms |
|
Note that all these optimizations became much more obvious after the ProgramConfiguration #3439 refactor. It made understanding how programs are created and used much easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with #3485, this PR brings the rendering performance with the Streets z13 benchmark to pre-DDS levels and closes #3342! 🎉🎉🎉 Benchmark results:
Changes:
Note that the failing build is due to changes in ESLint 3.9.0; fixed up the warnings in the third commit.
👀 @jfirebaugh @lucaswoj @ansis