-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix an iOS15 issue where Safari tab bar interrupts panning (#11084) #11101
Conversation
…11089) * fix an iOS15 issue where map stops when panning * fix tests and lint * Test drag pan handler does not end interaction on resize * Move blur event reset into non-touch handlers (#11087) * Move blur event reset into non-touch handlers * Fix linter * Fix/amend unit tests * Flush task queue in rotate test Co-authored-by: Ricky Reusser <ricky.reusser@mapbox.com> Co-authored-by: Ricky Reusser <rreusser@users.noreply.github.com> Co-authored-by: Vladimir Agafonkin <agafonkin@gmail.com>
Ah, I think the failing test is because I wrote a test that followed the (It would definitely be best to fix, but just in case that's really not straightforward for some reason, I wouldn't be extremely opposed to dropping that particular test since changes to these old release branches are so rare.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for tackling this!
Still having two unit tests fail: 'AttributionControl appears in compact mode if container is less then 640 pixel wide' and 'LogoControl appears in compact mode if container is less then 250 pixel wide'... I switched to clientWidth thinking possibly offWidth was causing it to fail. These two tests were here previously. Any ideas @rreusser ? |
I'm removing any change differences to those two unit tests from v1.13.2 branch, if it still breaks I think this line is causing it to break.... I suspect it's because it was changing the canvas container size in the unit tests instead of the container size, so it didn't trigger the resize. @SnailBones @arindam1993 @rreusser Would there ever be a case where there was a resize of the canvas and not container in the previous versions? Maybe there is a fix in a later version that resizes the container if the canvas was resized... |
@avpeery Is the compact mode Attribution and logo working in a debug page, tho? |
@arindam1993 - Yes both work in the debug page. |
@arindam1993 @rreusser @SnailBones attribution and logo compact mode both work in debug pages. It seems the two tests are failing at the container is a fake object which is does not have transform.width or transform.height. Would it be better to remove these two unit tests or attempt to resolve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once it looks good to circle-ci, LGTM!
Cherry-picks #11089 (including, by extension, #11087) into release v1.13.2.
fix an iOS15 issue where map stops when panning
fix tests and lint
Test drag pan handler does not end interaction on resize
Move blur event reset into non-touch handlers (Move blur event reset into non-touch handlers #11087)
Move blur event reset into non-touch handlers
Fix linter
Fix/amend unit tests
Flush task queue in rotate test
Co-authored-by: Ricky Reusser ricky.reusser@mapbox.com
Co-authored-by: Ricky Reusser rreusser@users.noreply.github.com
Co-authored-by: Vladimir Agafonkin agafonkin@gmail.com