Skip to content
This repository has been archived by the owner on Jun 14, 2024. It is now read-only.

Don't check in access token #58

Merged
merged 3 commits into from
Feb 3, 2017
Merged

Don't check in access token #58

merged 3 commits into from
Feb 3, 2017

Conversation

friedbunny
Copy link
Contributor

@friedbunny friedbunny commented Feb 2, 2017

Preparation for making this repo public (#40). The old access token has been revoked.

This requires you to add your token in APIKeys.plist — everyone will need to cp Examples/APIKeys.EXAMPLE.plist Examples/APIKeys.plist, then insert their token in that file under the MGLMapboxAccessToken key.

Switched to a plaintext mapbox_access_token file.

/cc @jmkiley @captainbarbosa @1ec5

@friedbunny friedbunny self-assigned this Feb 2, 2017
@friedbunny friedbunny requested a review from 1ec5 February 2, 2017 23:30
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer this approach to keeping an access token private, but that's largely a matter of personal preference. I would still prefer that a plain text file be used instead of a plist, because the plist format (dictionary containing a particular key) requires trial and error.

@friedbunny
Copy link
Contributor Author

friedbunny commented Feb 3, 2017

@1ec5 I’ll give your method a try tomorrow — the plist approach makes more sense when there’s more than one key, which isn’t the case here.

@friedbunny
Copy link
Contributor Author

@1ec5 Switched to your approach in d3f8448, defaulting to a git-ignored local file and falling back to ~/.mapbox.

@friedbunny friedbunny merged commit d9146db into master Feb 3, 2017
@friedbunny friedbunny deleted the fb-genericize-token branch February 3, 2017 17:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants