Correctly resolve Jupyter data/config dirs on Windows #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`juv run` Simplifies setup by avoiding temporary merged Jupyter data dir. Sets `JUPYTER_PATH` directly from known locations.
Should handle virtual env layout differences on Unix and Windows.
JUPYTER_PATH instead of creating merged JUPYTER_DATA_DIR for juv run|
AWESOME!!! you did it! thank you! I've got a button 😊!!! (and I verified that quak is also working as expected from #61 (I'll go close that!)) I'm excited to show this to some people at work! is it Monday yet!?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies how we set up Jupyter paths in
juv runand should hopefully fix (#61).Instead of creating a merged directory of Jupyter data files, we now just set
JUPYTER_PATHandJUPYTER_CONFIG_PATHdirectly based on what's available in the current virtual environment. This works better across platforms and avoids the complexity of copying, linking, deleting files.I think what is happening on Windows is that we weren’t correctly identifying the virtual environment root. Unix and Windows place
site-packagesat different depths, so the old logic would go up three levels regardless. Now we handle each case explicitly, which should make path resolution more reliable.I don't have a great way to test but would love if either @ATL2001 or @Jhsmit would give it a spin. I'm going to make a release either way, but would love to know if we can close #61.