Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ app can be minimized when close button click #232

Merged
merged 1 commit into from
Dec 3, 2022

Conversation

manusa
Copy link
Owner

@manusa manusa commented Dec 1, 2022

Part of #44

Due to inconsistencies in the tray icon behavior across the platforms (Linux, Mac, Windows) and with the purpose of offering a smooth and exact behavior in all of them, the browser window needs to be minimized instead of hidden.

When hiding the window in Linux, there's no way to detect when the user clicks on the Tray to invoke the BrowserWindow.show() function. Depending on the user's X environment different things might happen.

To avoid all of this, with the current implementation, the window is just minimized which means it will remain visible in the task bar. Unless the underlying Electron's Tray implementation is changed in the future, there's nothing else that can be done if a consistent behavior across platforms wants to be preserved.

@manusa manusa mentioned this pull request Dec 1, 2022
3 tasks
Signed-off-by: Marc Nuri <marc@marcnuri.com>
@manusa manusa force-pushed the feat/minimize-on-close branch from eedc6fb to 6518779 Compare December 1, 2022 06:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 9c0d727 into main Dec 3, 2022
@manusa manusa deleted the feat/minimize-on-close branch December 3, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant