fix: cri-dockerd always with execution permission

manusa · Dec 23, 2022 · 1e9b544 · 1e9b544
1 parent 17fbbaa
commit 1e9b544
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/__tests__/download.test.js b/src/__tests__/download.test.js
@@ -165,12 +165,12 @@ describe('download module test suite', () => {
     });
     test('should install cri-dockerd binary', async () => {
       // When
-      await download.installCriDockerd({githubToken: 'secret-token'});
+      await download.installCriDockerd();
       // Then
       expect(tc.extractTar).toHaveBeenCalledWith('cri-dockerd.tgz');
       expect(exec.logExecSync).toHaveBeenCalledWith(
         expect.stringMatching(
-          /sudo cp -a .+\/cri-dockerd\/cri-dockerd \/usr\/local\/bin\//
+          /sudo install -m 0755 .+\/cri-dockerd\/cri-dockerd \/usr\/local\/bin\//
         )
       );
       expect(exec.logExecSync).toHaveBeenCalledWith(

diff --git a/src/download.js b/src/download.js
@@ -72,7 +72,7 @@ const installCriDockerd = async (inputs = {}) => {
   // Binary
   const binaryDir = await tc.extractTar(binaryTar);
   const binaryContent = firstDir(binaryDir);
-  logExecSync(`sudo cp -a ${binaryDir}/${binaryContent}/cri-dockerd /usr/local/bin/`);
+  logExecSync(`sudo install -m 0755 ${binaryDir}/${binaryContent}/cri-dockerd /usr/local/bin/`);
   logExecSync(`sudo ln -sf /usr/local/bin/cri-dockerd /usr/bin/cri-dockerd`);
   // Service file
   const sourceTar = await tc.downloadTool(`https://github.com/Mirantis/cri-dockerd/archive/refs/tags/${tag}.tar.gz`);