Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@mantine/core] Select: only use open/close callback when value changes #858

Merged
merged 2 commits into from
Feb 19, 2022
Merged

[@mantine/core] Select: only use open/close callback when value changes #858

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
846e180
[@mantine/core] Select: only use open/close callback when value changes
wes337 Feb 19, 2022
9e8045f
[@mantine/core] Select: do not use early return
wes337 Feb 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/mantine-core/src/components/Select/Select.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,10 @@ export const Select = forwardRef<HTMLInputElement, SelectProps>(
const isDeselectable = allowDeselect === undefined ? clearable : allowDeselect;

const setDropdownOpened = (opened: boolean) => {
if (dropdownOpened === opened) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change code a little to make it consistent with the rest of codebase: do not use early returns, replace it with if condition istead:

if (dropdownOpened !== opened) {
      _setDropdownOpened(opened);
      const handler = opened ? onDropdownOpen : onDropdownClose;
      typeof handler === 'function' && handler();
}

return;
}

_setDropdownOpened(opened);
const handler = opened ? onDropdownOpen : onDropdownClose;
typeof handler === 'function' && handler();
Expand Down