-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@mantine/core] Grid: Fix offset and order responsive props #2163
[@mantine/core] Grid: Fix offset and order responsive props #2163
Conversation
maxWidth: grow | ||
? 'unset' | ||
: typeof sizes[size] === 'number' | ||
? getColumnWidth(sizes[size], columns) | ||
: 'none', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super in love with the double ternary statement so open to feedback here. If the sizes[size]
isn't defined, we just use the initial value for that CSS property (none
in the case of max-width
and auto
in the case of flexBasis
).
Thanks! |
@mdodell this PR broke all Grid responsive styles, I've reverted it |
Interesting. I'll submit a follow-up PR, I think that the check for |
No need, I've already resolved the isuue |
Ah - perfect. My apologies here. Is it now resolved so that the It looks like currently the values rae being set to |
…antinedev#2163)" This reverts commit 0326f9b.
…antinedev#2163)" This reverts commit 0326f9b.
Fixes issue with both
offset
andorder
props forGrid.Col
that requires each to have a responsive prop (xs
,sm
,md
,lg
,xl
) for their respective responsive props (offsetXs
,orderXs
, etc). to work.Also updated the docs for
order
to properly useGrid.Col
rather than theCol
shorthand.