[@mantine/core] Multiselect: match styles of TextInput #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wes337
commented
Aug 18, 2022
| appearance: 'none', | ||
| color: 'inherit', | ||
| lineHeight: `${theme.fn.size({ size, sizes: INPUT_SIZES }) - 2}px`, |
There was a problem hiding this comment.
This is the same way the line height is calculated in the Input styles
There was a problem hiding this comment.
Will in work correctly is MultiSelect has multiple lines? It happens when there are a lot of items selected.
There was a problem hiding this comment.
Seems fine to me:
Chrome:
Edge:
The items are not actually part of the input element. But the placeholder text is.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes differences between
MultiselectandTextInputstyles.Chrome:
Edge:
Firefox:
Same height (30px for XS):
Resolves #1962