[@mantine/nprogress] Init #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtivital can you please review this PR (I'm not really good at writing documents) |
|
Currently there is still one problem im not sure how to solve and that is when you want to restart the nprogress directly after it faded out because then it will not be visible for x ms (I will look in to that problem later this day) |
rtivital
reviewed
Apr 13, 2022
* [@mantine/hooks] use-fullscreen: custom ref state Added a check to ensure a custom ref element toggles the fullscreen state * fixed the prettier issue
…#1219) * [@mantine/core] Select: only use open/close callback when value changes * [@mantine/core] Select: do not use early return * [@mantine/core] Tooltip: floating tooltip positioned inside component instead of popper * [@mantine/core] Tooltip: revert positions story back * [@mantine/core] Tooltip: remove popper from floating tooltip * [@mantine/core] Tooltip: fix floating tooltip test, add position deps to coordinates array * [@mantine/core] Tooltip: remove extra div
|
I rebased the PR and updated the prop names
This is now also fixed @rtivital Can you check the PR |
rtivital
reviewed
Apr 15, 2022
|
Thanks, great job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new version of my old PR (Complete rewrite)
New PR of old PR but based on the master branch