[@mantine/prism] Fix prism number spacing #1156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtivital
reviewed
Apr 1, 2022
| @@ -42,8 +42,9 @@ export default createStyles((theme, { colorScheme, native }: PrismStylesParams) | |||
| lineNumber: { | |||
| color: colorScheme === 'dark' ? theme.colors.dark[4] : theme.colors.gray[4], | |||
| textAlign: 'right', | |||
| paddingRight: theme.dir === 'ltr' ? theme.spacing.xl : undefined, | |||
| paddingLeft: theme.dir === 'rtl' ? theme.spacing.xl : undefined, | |||
| minWidth: 43, | |||
There was a problem hiding this comment.
Will it fix the issue for triple digits, e.g. 122?
There was a problem hiding this comment.
above code fix the digit but need space so looks clean
like this
width: 43,
marginRight: theme.dir === 'ltr' ? theme.spacing.xs : undefined,
marginLeft: theme.dir === 'rtl' ? theme.spacing.xs : undefined,
either use minWidth or width. minWidth can use for support lines more than 65535 or 100000.
but if use width will force content so the number will overlap with the code (when reached 100000). same behaviour if use IE that need support minWidth and maxWidth that same effect with width on normal browser
There was a problem hiding this comment.
if just support three lines number, only need 25
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use min-width of max lines 65535 like VSCode.
user can easy override with styles. if they want smaller space caused only small lines code