Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs with undefined params #985

Closed
eliomaria opened this issue Mar 11, 2022 · 1 comment
Closed

Inputs with undefined params #985

eliomaria opened this issue Mar 11, 2022 · 1 comment

Comments

@eliomaria
Copy link

What package has an issue

@mantine/core

Describe the bug

A lot of params for the various types of inputs, in the v4.0 dont allow to pass undefined anymore, to be able to manage some of the params as options in a parent component for example. Its for some specific reason? Or can we put back the undefined to use default behaviours?

Examples:
Button -> gradient, rightIcon with undefined
Select -> itemComponent as undefined
Multi-Select -> valueComponent, itemComponent as undefined

In which browser did the problem occur

all

If possible, please include a link to a codesandbox with the reproduced problem

No response

Do you know how to fix the issue

Yes

Are you willing to participate in fixing this issue and create a pull request with the fix

Yes

Possible fix

Analyse the prop to see if its undefined before trying to use it and callback for default.

@eliomaria eliomaria added the bug label Mar 11, 2022
rtivital added a commit that referenced this issue Mar 11, 2022
@rtivital
Copy link
Member

Fixed in 4.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants