Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Padding missing on right side of scrollable Combobox dropdown #7450

Closed
1 of 2 tasks
BenjaminGolba opened this issue Feb 5, 2025 · 1 comment
Closed
1 of 2 tasks
Labels
Fixed Completed issues that will be published with next patch (1.0.X)

Comments

@BenjaminGolba
Copy link

BenjaminGolba commented Feb 5, 2025

Dependencies check up

  • I have verified that I use latest version of all @mantine/* packages

What version of @mantine/* packages do you have in package.json?

7.16.2

What package has an issue?

@mantine/core

What framework do you use?

Other, I will specify in the bug description

In which browsers you can reproduce the issue?

Chrome

Describe the bug

Seems to me that there is a padding-inline-end placed on the mantine-Combobox-Dropdown portal, which aims to align the scrollbar with the padding on the dropdown area. This does however also remove the padding for the actual options as well, which is primarily visible when there is a background attached to a option.

No padding (Not OK) in a scrollable Combobox:
Image

Padding (OK) in a non-scrollable Combobox:
Image

Suspected source of the bug: padding-inline-end
Image

If possible, include a link to a codesandbox with a minimal reproduction

https://mantine.dev/core/combobox/#scrollable-list

  1. Inspect the scrollable list
  2. Select an item
  3. Open the dropdown again
  4. Take a look at the background of the selected item (I overrode the background color of the active item for clarity) > Item has no padding

Possible fix

No response

Self-service

  • I would be willing to implement a fix for this issue
@rtivital rtivital added the Fixed Completed issues that will be published with next patch (1.0.X) label Feb 8, 2025
@rtivital
Copy link
Member

rtivital commented Feb 8, 2025

Fixed in 7.16.3

@rtivital rtivital closed this as completed Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fixed Completed issues that will be published with next patch (1.0.X)
Projects
None yet
Development

No branches or pull requests

2 participants