Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Numberinput doesn't trigger a onChange #516

Closed
converter-user-old opened this issue Dec 14, 2021 · 2 comments
Closed

Numberinput doesn't trigger a onChange #516

converter-user-old opened this issue Dec 14, 2021 · 2 comments
Labels
help wanted Contributions from community are welcome

Comments

@converter-user-old
Copy link
Contributor

converter-user-old commented Dec 14, 2021 •
edited
Loading

I am not sure if this is really a problem.

If you have precision on for example 2 and you write a number like 0.0012 and then blur the input field the value of the state is still 0.0012 but the UI shows 0.00

  • What package has an issue (@mantine/core, mantine/hooks or other)? @mantine/core
  • What package version are you using? 3.4.0
  • In which browser and operating system issue occurred? Windows 10 Edge@96.0.1054.53
  • If possible please attach link to codesandbox with reproduced issue: https://codesandbox.io/s/nice-moore-4tgf3

image
@rtivital
Copy link
Member

Thanks for reporting, I'll try to fix it, but you (or anyone else) are welcome to contribute this feature if “Help wanted” label is still on the issue

@rtivital rtivital added the help wanted Contributions from community are welcome label Dec 14, 2021
@jerebtw jerebtw mentioned this issue Dec 14, 2021
Merged
rtivital pushed a commit that referenced this issue Dec 16, 2021
@jerebtw
[@mantine/core] NumberInput: Fix incorrect onChange value with high p…
8827dda 
…recision (#518)

* Fix for #516

* Fix for #519

* Add use-os story

* Formatting error corrected

* Added a check for the precision on blur
@rtivital
Copy link
Member

Fixed in 3.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contributions from community are welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rtivital @converter-user-old